From 9eca7a02d9b0d7cde55e524e1bb9e009ea1544c3 Mon Sep 17 00:00:00 2001
From: Jay <wisehodl@pm.me>
Date: Sun, 17 May 2026 11:47:18 -0400
Subject: [PATCH] session: move termExternal/done assertion into dedicated
 subtest

---
 request_test.go | 40 ++++++++++++++++++++++++++--------------
 1 file changed, 26 insertions(+), 14 deletions(-)

diff --git a/request_test.go b/request_test.go
index d08d235..90896cf 100644
--- a/request_test.go
+++ b/request_test.go
@@ -124,17 +124,6 @@ func TestRequestManager_Session(t *testing.T) {
 				return false
 			}
 		}, "terminate should not be called on eose for stream")
-
-		// session is still running; done closes it cleanly
-		close(h.done)
-		Eventually(t, func() bool {
-			select {
-			case r := <-h.terminatedWith:
-				return r == termExternal
-			default:
-				return false
-			}
-		}, "expected termExternal after done closed")
 	})
 
 	t.Run("sends close on eose if query", func(t *testing.T) {
@@ -179,9 +168,32 @@ func TestRequestManager_Session(t *testing.T) {
 	})
 
 	t.Run("terminates on done close", func(t *testing.T) {
-		// construct a session with a done channel
-		// close the done channel
-		// assert terminate was called with termExternal
+		h := newMockSessionHarness()
+		s := newSession(
+			h.ctx, h.id, h.req, h.eose, h.closed, h.done,
+			h.send, h.terminate, false, nil)
+		go s.run()
+
+		// wait for initial req
+		Eventually(t, func() bool {
+			select {
+			case <-h.sent:
+				return true
+			default:
+				return false
+			}
+		}, "expected initial send")
+
+		// close with done
+		close(h.done)
+		Eventually(t, func() bool {
+			select {
+			case r := <-h.terminatedWith:
+				return r == termExternal
+			default:
+				return false
+			}
+		}, "expected termExternal after done closed")
 	})
 
 	t.Run("terminates on context cancel", func(t *testing.T) {