From 22b385f2400e1919dce0e2acf370ec10ccf1c73b Mon Sep 17 00:00:00 2001
From: Jay <jay@wisehodl.dev>
Date: Sun, 9 Aug 2026 19:02:39 -0400
Subject: [PATCH] security: prevent send-on-close panic

Move channel sends into mutex lock to prevent channel closure from racing with the send.
Add a buffer to the event and inbox channels for backpressure management.
---
 embassy.go | 32 +++++++++++++-------------------
 1 file changed, 13 insertions(+), 19 deletions(-)

diff --git a/embassy.go b/embassy.go
index 2ece61d..9ebac2f 100644
--- a/embassy.go
+++ b/embassy.go
@@ -214,7 +214,7 @@ func (e *Embassy) send(url string, data []byte) error {
 }
 
 func (e *Embassy) subscribeEventsLock(url string) <-chan PoolEvent {
-	ch := make(chan PoolEvent)
+	ch := make(chan PoolEvent, 256)
 	e.eventSubs[url] = ch
 	return ch
 }
@@ -229,7 +229,7 @@ func (e *Embassy) unsubscribeEventsLock(url string) {
 }
 
 func (e *Embassy) subscribeInboxLock(url string) <-chan InboxMessage {
-	ch := make(chan InboxMessage)
+	ch := make(chan InboxMessage, 256)
 	e.inboxSubs[url] = ch
 	return ch
 }
@@ -258,21 +258,18 @@ func (e *Embassy) routeEvents() {
 				continue
 			}
 
-			e.mu.RLock()
-			sub, ok := e.eventSubs[url]
-			e.mu.RUnlock()
+			e.mu.Lock()
+			ch, ok := e.eventSubs[url]
 
 			if !ok {
+				e.mu.Unlock()
 				continue
 			}
 
-			select {
-			case <-e.ctx.Done():
-				return
-			case sub <- PoolEvent{
+			ch <- PoolEvent{
 				URL: ev.URL, Kind: mapEmbassyEvent(ev.Kind), At: ev.At, Err: ev.Err,
-			}:
 			}
+			e.mu.Unlock()
 		}
 	}
 }
@@ -292,20 +289,17 @@ func (e *Embassy) routeInbox() {
 				continue
 			}
 
-			e.mu.RLock()
-			sub, ok := e.inboxSubs[url]
-			e.mu.RUnlock()
+			e.mu.Lock()
+			ch, ok := e.inboxSubs[url]
 
 			if !ok {
+				e.mu.Unlock()
 				continue
 			}
 
-			select {
-			case <-e.ctx.Done():
-				return
-			case sub <- InboxMessage{
-				URL: ev.URL, Data: ev.Data, ReceivedAt: ev.ReceivedAt}:
-			}
+			ch <- InboxMessage{
+				URL: ev.URL, Data: ev.Data, ReceivedAt: ev.ReceivedAt}
+			e.mu.Unlock()
 		}
 	}
 }