Various performance and correctness improvements.

outbound/worker.go

@@ -1,9 +1,10 @@
 package outbound
 
 import (
-	"container/list"
 	"context"
+	"git.wisehodl.dev/jay/go-honeybee/queue"
 	"git.wisehodl.dev/jay/go-honeybee/transport"
+	"git.wisehodl.dev/jay/go-honeybee/types"
 	"sync"
 	"sync/atomic"
 	"time"
@@ -17,11 +18,6 @@ type Worker interface {
 	Send(data []byte) error
 }
 
-type ReceivedMessage struct {
-	data       []byte
-	receivedAt time.Time
-}
-
 type DefaultWorker struct {
 	id        string
 	conn      atomic.Pointer[transport.Connection]
@@ -59,11 +55,12 @@ func NewWorker(
 func (w *DefaultWorker) Start(pool PoolPlugin) {
 	dial := make(chan struct{}, 1)
 	newConn := make(chan *transport.Connection, 1)
-	messages := make(chan ReceivedMessage, 256)
+	toQueue := make(chan types.ReceivedMessage, 256)
+	toForwarder := make(chan types.ReceivedMessage, 256)
 	keepalive := make(chan struct{}, 1)
 
 	var wg sync.WaitGroup
-	wg.Add(4)
+	wg.Add(5)
 
 	go func() {
 		defer wg.Done()
@@ -77,7 +74,12 @@ func (w *DefaultWorker) Start(pool PoolPlugin) {
 
 	go func() {
 		defer wg.Done()
-		RunForwarder(w.id, w.ctx, messages, pool.Inbox, w.config.MaxQueueSize)
+		queue.RunQueue(w.id, w.ctx, toQueue, toForwarder, w.config.MaxQueueSize)
+	}()
+
+	go func() {
+		defer wg.Done()
+		RunForwarder(w.id, w.ctx, toForwarder, pool.Inbox)
 	}()
 
 	go func() {
@@ -85,7 +87,7 @@ func (w *DefaultWorker) Start(pool PoolPlugin) {
 		session := &Session{
 			id:        w.id,
 			connPtr:   &w.conn,
-			messages:  messages,
+			messages:  toQueue,
 			heartbeat: w.heartbeat,
 			dial:      dial,
 			keepalive: keepalive,
@@ -124,7 +126,7 @@ type Session struct {
 	id      string
 	connPtr *atomic.Pointer[transport.Connection]
 
-	messages  chan<- ReceivedMessage
+	messages  chan<- types.ReceivedMessage
 	heartbeat chan<- struct{}
 	dial      chan<- struct{}
 
@@ -203,7 +205,7 @@ func RunReader(
 	ctx context.Context,
 	onStop func(),
 	conn *transport.Connection,
-	messages chan<- ReceivedMessage,
+	messages chan<- types.ReceivedMessage,
 	heartbeat chan<- struct{},
 ) {
 	defer func() {
@@ -222,7 +224,7 @@ func RunReader(
 			}
 
 			// send message forward
-			messages <- ReceivedMessage{data: data, receivedAt: time.Now()}
+			messages <- types.ReceivedMessage{Data: data, ReceivedAt: time.Now()}
 
 			// send heartbeat
 			select {
@@ -254,43 +256,27 @@ func RunStopMonitor(
 func RunForwarder(
 	id string,
 	ctx context.Context,
-	messages <-chan ReceivedMessage,
+	messages <-chan types.ReceivedMessage,
 	inbox chan<- InboxMessage,
-	maxQueueSize int,
 ) {
-	queue := list.New()
-
 	for {
-		var out chan<- InboxMessage
-		var next ReceivedMessage
-
-		// enable inbox if it is populated
-		if queue.Len() > 0 {
-			out = inbox
-
-			// read the first message in the queue
-			next = queue.Front().Value.(ReceivedMessage)
-		}
-
 		select {
 		case <-ctx.Done():
 			return
-		case msg := <-messages:
-			// limit queue size if maximum is configured
-			if maxQueueSize > 0 && queue.Len() >= maxQueueSize {
-				// drop oldest message
-				queue.Remove(queue.Front())
+		case msg, ok := <-messages:
+			if !ok {
+				return
+			}
+			select {
+			case <-ctx.Done():
+				return
+
+			case inbox <- InboxMessage{
+				ID:         id,
+				Data:       msg.Data,
+				ReceivedAt: msg.ReceivedAt,
+			}:
 			}
-			// add new message
-			queue.PushBack(msg)
-		// send next message to inbox
-		case out <- InboxMessage{
-			ID:         id,
-			Data:       next.data,
-			ReceivedAt: next.receivedAt,
-		}:
-			// drop message from queue
-			queue.Remove(queue.Front())
 		}
 	}
 }