removed pool errors channels

inbound/config.go

@@ -20,7 +20,6 @@ type WorkerFactory func(
 type PoolConfig struct {
 	InboxBufferSize  int
 	EventsBufferSize int
-	ErrorsBufferSize int
 	LoggingEnabled   bool
 	LogLevel         *slog.Level
 	ConnectionConfig *transport.ConnectionConfig
@@ -45,7 +44,6 @@ func GetDefaultPoolConfig() *PoolConfig {
 	return &PoolConfig{
 		InboxBufferSize:  256,
 		EventsBufferSize: 10,
-		ErrorsBufferSize: 10,
 		LoggingEnabled:   true,
 		LogLevel:         nil,
 		ConnectionConfig: nil,
@@ -104,16 +102,6 @@ func WithEventsBufferSize(value int) PoolOption {
 	}
 }
 
-func WithErrorsBufferSize(value int) PoolOption {
-	return func(c *PoolConfig) error {
-		if err := validateBufferSize(value); err != nil {
-			return err
-		}
-		c.ErrorsBufferSize = value
-		return nil
-	}
-}
-
 func WithPoolLoggingEnabled(value bool) PoolOption {
 	return func(c *PoolConfig) error {
 		c.LoggingEnabled = value

inbound/config_test.go

@@ -105,7 +105,6 @@ func TestDefaultPoolConfig(t *testing.T) {
 	assert.Equal(t, &PoolConfig{
 		InboxBufferSize:  256,
 		EventsBufferSize: 10,
-		ErrorsBufferSize: 10,
 		LoggingEnabled:   true,
 		LogLevel:         nil,
 		ConnectionConfig: nil,
@@ -174,7 +173,6 @@ func TestWithBufferSizes(t *testing.T) {
 	err := applyPoolOptions(conf,
 		WithInboxBufferSize(100),
 		WithEventsBufferSize(20),
-		WithErrorsBufferSize(20),
 	)
 	assert.NoError(t, err)
 	assert.Equal(t, 100, conf.InboxBufferSize)

inbound/pool.go

@@ -41,7 +41,6 @@ type PoolEvent struct {
 type PoolStats struct {
 	ChanInbox  int
 	ChanEvents int
-	ChanErrors int
 
 	TotalReceived uint64
 	TotalSent     uint64
@@ -59,7 +58,6 @@ type PeerStats struct {
 type PoolPlugin struct {
 	Inbox        chan<- types.InboxMessage
 	Events       chan<- PoolEvent
-	Errors       chan<- error
 	InboxCounter *atomic.Uint64
 	OnExit       OnExitFunction
 	Handler      slog.Handler
@@ -83,7 +81,6 @@ type Pool struct {
 	peers  map[string]*Peer
 	inbox  chan types.InboxMessage
 	events chan PoolEvent
-	errors chan error
 
 	inboxCounter  *atomic.Uint64
 	outgoingCount *atomic.Uint64
@@ -140,7 +137,6 @@ func NewPool(ctx context.Context, id string, config *PoolConfig, handler slog.Ha
 		peers:         make(map[string]*Peer),
 		inbox:         make(chan types.InboxMessage, config.InboxBufferSize),
 		events:        make(chan PoolEvent, config.EventsBufferSize),
-		errors:        make(chan error, config.ErrorsBufferSize),
 		inboxCounter:  &atomic.Uint64{},
 		outgoingCount: &atomic.Uint64{},
 		config:        config,
@@ -169,10 +165,6 @@ func (p *Pool) Events() <-chan PoolEvent {
 	return p.events
 }
 
-func (p *Pool) Errors() <-chan error {
-	return p.errors
-}
-
 func (p *Pool) Stats() PoolStats {
 	p.mu.RLock()
 	defer p.mu.RUnlock()
@@ -190,7 +182,6 @@ func (p *Pool) Stats() PoolStats {
 	return PoolStats{
 		ChanInbox:  len(p.inbox),
 		ChanEvents: len(p.events),
-		ChanErrors: len(p.errors),
 
 		TotalReceived: p.inboxCounter.Load(),
 		TotalSent:     p.outgoingCount.Load(),
@@ -245,7 +236,6 @@ func (p *Pool) Close() {
 		p.wg.Wait()
 		close(p.inbox)
 		close(p.events)
-		close(p.errors)
 
 		if p.logger != nil {
 			p.logger.Info("closed")
@@ -386,7 +376,6 @@ func (p *Pool) addLocked(id string, socket types.Socket) error {
 	pool := PoolPlugin{
 		Inbox:        p.inbox,
 		Events:       p.events,
-		Errors:       p.errors,
 		InboxCounter: p.inboxCounter,
 		OnExit:       onExit,
 		Handler:      p.handler,