From 3ea4393876cfd8d76d66c93a796a99c20405c8d7 Mon Sep 17 00:00:00 2001 From: Jay Date: Thu, 4 Jun 2026 20:36:52 -0400 Subject: [PATCH] Set 10s TCP dial timeout on GorillaDialer via NetDialContext --- transport/socket.go | 8 +++++--- transport/socket_test.go | 4 +--- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/transport/socket.go b/transport/socket.go index 1676a5d..1304316 100644 --- a/transport/socket.go +++ b/transport/socket.go @@ -3,6 +3,7 @@ package transport import ( "context" "log/slog" + "net" "net/http" "time" @@ -18,12 +19,13 @@ type GorillaDialer struct { *websocket.Dialer } +const dialTimeout = 10 * time.Second + func NewGorillaDialer() *GorillaDialer { + netDialer := &net.Dialer{Timeout: dialTimeout} return &GorillaDialer{ Dialer: &websocket.Dialer{ - HandshakeTimeout: 45 * time.Second, - ReadBufferSize: 1024, - WriteBufferSize: 1024, + NetDialContext: netDialer.DialContext, }, } } diff --git a/transport/socket_test.go b/transport/socket_test.go index 7d19916..c0bcf5b 100644 --- a/transport/socket_test.go +++ b/transport/socket_test.go @@ -27,9 +27,7 @@ func TestNewGorillaDialer(t *testing.T) { assert.NotNil(t, dialer) assert.NotNil(t, dialer.Dialer) - assert.Equal(t, 45*time.Second, dialer.Dialer.HandshakeTimeout) - assert.Equal(t, 1024, dialer.Dialer.ReadBufferSize) - assert.Equal(t, 1024, dialer.Dialer.WriteBufferSize) + assert.NotNil(t, dialer.Dialer.NetDialContext) } func TestAcquireSocket(t *testing.T) {