Updated name.

This commit is contained in:
Jay
2026-04-20 18:05:32 -04:00
parent 2c7b22b3d9
commit 111d813bdf
3 changed files with 17 additions and 17 deletions
+6 -6
View File
@@ -47,7 +47,7 @@ func ValidateWorkerConfig(config *WorkerConfig) error {
if err := validateMaxQueueSize(config.MaxQueueSize); err != nil { if err := validateMaxQueueSize(config.MaxQueueSize); err != nil {
return err return err
} }
if err := validateDeadTimeout(config.InactivityTimeout); err != nil { if err := validateInactivityTimeout(config.InactivityTimeout); err != nil {
return err return err
} }
return nil return nil
@@ -60,9 +60,9 @@ func validateMaxQueueSize(value int) error {
return nil return nil
} }
func validateDeadTimeout(value time.Duration) error { func validateInactivityTimeout(value time.Duration) error {
if value < 0 { if value < 0 {
return InvalidDeadTimeout return InvalidInactivityTimeout
} }
return nil return nil
} }
@@ -78,10 +78,10 @@ func WithMaxQueueSize(value int) WorkerOption {
} }
} }
// When DeadTimeout is zero, the watchdog is disabled. // When InactivityTimeout is zero, the watchdog is disabled.
func WithDeadTimeout(value time.Duration) WorkerOption { func WithInactivityTimeout(value time.Duration) WorkerOption {
return func(c *WorkerConfig) error { return func(c *WorkerConfig) error {
if err := validateDeadTimeout(value); err != nil { if err := validateInactivityTimeout(value); err != nil {
return err return err
} }
c.InactivityTimeout = value c.InactivityTimeout = value
+9 -9
View File
@@ -33,11 +33,11 @@ func TestValidateWorkerConfig(t *testing.T) {
conf: *GetDefaultWorkerConfig(), conf: *GetDefaultWorkerConfig(),
}, },
{ {
name: "zero dead timeout disabled", name: "zero inactivity timeout disabled",
conf: WorkerConfig{InactivityTimeout: 0}, conf: WorkerConfig{InactivityTimeout: 0},
}, },
{ {
name: "positive dead timeout", name: "positive inactivity timeout",
conf: WorkerConfig{InactivityTimeout: 30 * time.Second}, conf: WorkerConfig{InactivityTimeout: 30 * time.Second},
}, },
{ {
@@ -46,9 +46,9 @@ func TestValidateWorkerConfig(t *testing.T) {
wantErr: InvalidMaxQueueSize, wantErr: InvalidMaxQueueSize,
}, },
{ {
name: "negative dead timeout", name: "negative inactivity timeout",
conf: WorkerConfig{InactivityTimeout: -1 * time.Second}, conf: WorkerConfig{InactivityTimeout: -1 * time.Second},
wantErr: InvalidDeadTimeout, wantErr: InvalidInactivityTimeout,
}, },
} }
@@ -78,18 +78,18 @@ func TestWithMaxQueueSize(t *testing.T) {
assert.ErrorIs(t, err, InvalidMaxQueueSize) assert.ErrorIs(t, err, InvalidMaxQueueSize)
} }
func TestWithDeadTimeout(t *testing.T) { func TestWithInactivityTimeout(t *testing.T) {
conf := &WorkerConfig{} conf := &WorkerConfig{}
err := applyWorkerOptions(conf, WithDeadTimeout(30*time.Second)) err := applyWorkerOptions(conf, WithInactivityTimeout(30*time.Second))
assert.NoError(t, err) assert.NoError(t, err)
assert.Equal(t, 30*time.Second, conf.InactivityTimeout) assert.Equal(t, 30*time.Second, conf.InactivityTimeout)
err = applyWorkerOptions(conf, WithDeadTimeout(0)) err = applyWorkerOptions(conf, WithInactivityTimeout(0))
assert.NoError(t, err) assert.NoError(t, err)
err = applyWorkerOptions(conf, WithDeadTimeout(-1*time.Second)) err = applyWorkerOptions(conf, WithInactivityTimeout(-1*time.Second))
assert.ErrorIs(t, err, InvalidDeadTimeout) assert.ErrorIs(t, err, InvalidInactivityTimeout)
} }
func TestNewPoolConfig(t *testing.T) { func TestNewPoolConfig(t *testing.T) {
+1 -1
View File
@@ -11,5 +11,5 @@ var (
// Config errors // Config errors
InvalidMaxQueueSize = errors.New("maximum queue size cannot be negative") InvalidMaxQueueSize = errors.New("maximum queue size cannot be negative")
InvalidDeadTimeout = errors.New("dead timeout cannot be negative") InvalidInactivityTimeout = errors.New("inactivity timeout cannot be negative")
) )